Skip to content

Disable flaky test in summaries #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Mar 22, 2023

Description

There are two problems with SummaryOfMathTest

  • they are ugly
  • they are flaky

Finally, I decided to agree with Alexey Zinoviev and disable them.
There is a known issue #826 to enable them.

How to test

Testing is not required

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-summaries Something related to the method names, code comments and display names generation ctg-bug-fix PR is fixing a bug labels Mar 22, 2023
@EgorkaKulikov EgorkaKulikov requested a review from mmvpm March 22, 2023 13:10
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 22, 2023 13:11
@EgorkaKulikov EgorkaKulikov merged commit 765da9a into main Mar 22, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/disable_flaky_summary_test branch March 22, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-summaries Something related to the method names, code comments and display names generation ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants